Skip to content

Chore(evm) add combine pricefeed #2665

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 24 commits into
base: main
Choose a base branch
from

Conversation

aditya520
Copy link
Member

@aditya520 aditya520 commented May 8, 2025

Summary

Rationale

How has this been tested?

  • Current tests cover my changes
  • Added new tests
  • Manually tested the code

Copy link

vercel bot commented May 8, 2025

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
api-reference ✅ Ready (Inspect) Visit Preview 💬 Add feedback Jun 19, 2025 2:48pm
7 Skipped Deployments
Name Status Preview Comments Updated (UTC)
component-library ⬜️ Skipped (Inspect) Jun 19, 2025 2:48pm
developer-hub ⬜️ Skipped (Inspect) Jun 19, 2025 2:48pm
entropy-debugger ⬜️ Skipped (Inspect) Jun 19, 2025 2:48pm
entropy-explorer ⬜️ Skipped (Inspect) Jun 19, 2025 2:48pm
insights ⬜️ Skipped (Inspect) Jun 19, 2025 2:48pm
proposals ⬜️ Skipped (Inspect) Jun 19, 2025 2:48pm
staking ⬜️ Skipped (Inspect) Jun 19, 2025 2:48pm

@aditya520 aditya520 marked this pull request as ready for review May 9, 2025 18:40
@vercel vercel bot temporarily deployed to Preview – developer-hub June 19, 2025 13:05 Inactive
@vercel vercel bot temporarily deployed to Preview – entropy-debugger June 19, 2025 13:06 Inactive
@vercel vercel bot temporarily deployed to Preview – developer-hub June 19, 2025 13:06 Inactive
@vercel vercel bot temporarily deployed to Preview – component-library June 19, 2025 13:06 Inactive
@vercel vercel bot temporarily deployed to Preview – entropy-explorer June 19, 2025 13:06 Inactive
@vercel vercel bot temporarily deployed to Preview – proposals June 19, 2025 13:06 Inactive
@vercel vercel bot temporarily deployed to Preview – insights June 19, 2025 13:06 Inactive
@vercel vercel bot temporarily deployed to Preview – staking June 19, 2025 13:06 Inactive
@vercel vercel bot temporarily deployed to Preview – insights June 19, 2025 13:27 Inactive
@vercel vercel bot temporarily deployed to Preview – proposals June 19, 2025 13:27 Inactive
@vercel vercel bot temporarily deployed to Preview – developer-hub June 19, 2025 13:27 Inactive
@vercel vercel bot temporarily deployed to Preview – staking June 19, 2025 13:27 Inactive
@vercel vercel bot temporarily deployed to Preview – entropy-debugger June 19, 2025 13:27 Inactive
@vercel vercel bot temporarily deployed to Preview – component-library June 19, 2025 13:27 Inactive
@vercel vercel bot temporarily deployed to Preview – entropy-explorer June 19, 2025 13:27 Inactive
@aditya520 aditya520 requested a review from jayantk June 19, 2025 14:41
@vercel vercel bot temporarily deployed to Preview – staking June 19, 2025 14:46 Inactive
@vercel vercel bot temporarily deployed to Preview – entropy-explorer June 19, 2025 14:46 Inactive
@vercel vercel bot temporarily deployed to Preview – entropy-debugger June 19, 2025 14:46 Inactive
@vercel vercel bot temporarily deployed to Preview – insights June 19, 2025 14:46 Inactive
@vercel vercel bot temporarily deployed to Preview – proposals June 19, 2025 14:46 Inactive
@vercel vercel bot temporarily deployed to Preview – developer-hub June 19, 2025 14:46 Inactive
@vercel vercel bot temporarily deployed to Preview – component-library June 19, 2025 14:46 Inactive
Copy link
Contributor

@jayantk jayantk left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

nicely done.

/// @notice This function doesn't return the combined confidence interval.
/// This function will revert with PythErrors.ExponentOverflow if the combined exponent (targetExpo + expo1 - expo2) is greater than 58 or less than -58.
/// Assuming the combined exponent is within bounds, this function will work for full range of int64 prices.
/// The result of the computation is rounded down. In particular, if the result is < 1 in the delta exponent, it will be rounded to 0
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

in the targetExponent

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants